Issue 144 remove named objects #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters; updated documentation
ddsharpe
requested changes
Aug 19, 2019
ddsharpe
previously approved these changes
Aug 20, 2019
rosemarymarano
previously approved these changes
Aug 21, 2019
rakillen
changed the title
ddsharpe
previously approved these changes
Aug 22, 2019
CarolynRountree
suggested changes
Aug 22, 2019
There was a problem hiding this comment.
I see your message below. Since it fails on the set and not the updateDomain, that's good (I don't understand why WDT only looks up the existing servers in offline mode).
I looked at the setServerGroups code, this also looks at the existing servers and clusters. So a "forgotten" reference to a deleted server or cluster in the domainInfo targeting limits section seems to be handled.
…into issue-144-remove-named-objects
ddsharpe
approved these changes
Aug 22, 2019
CarolynRountree
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144.